Possible PrefsObjectsEditor bug

[trixie]

The SYS:Utilities/PrefsObjectsEditor tool seems to work fine - unless you run MemGuard, which reveals a hit. This is the relevant Sashimi output:

Dump of context at 0x7fd70ba0
Trap type: DSI exception
Machine State (raw): 0x2f030
Machine State (verbose): [ExtInt on] [User] [FPU on] [IAT on] [DAT on]
Instruction pointer: 0x1902ab0
Crashed process: PrefsObjectsEditor (0x56b37340)
0: 0000000d 54c11410 00000000 56b37340 00000000 01902aa0 01902aa0 020a9824
8: 5fdf95d0 02260000 554b2e60 01816cfc 42422024 58cba1fc 00000000 00000000
16: 566566c0 6f8c360c 00000000 155aa23c 58cb0000 54c118c0 02260000 00000000
24: 00000400 54c118c0 20000000 54c11448 56b37340 060e161c 00000000 81838587
CR: 48422042 XER: 00000008 CTR: 01816cfc LR: 01902aa0
ESR: 00000000
DEAR: 060e1628
mcsrr0: 0x0
csrr0: 0x0

Disassembly of crash site:
01902aa0: 7c7c1b79 mr. r28,r3
01902aa4: 41820074 beq- 0x1902B18
01902aa8: 57fd103b rlwinm. r29,r31,2,0,29
01902aac: 4182006c beq- 0x1902B18
>01902ab0: 83dd000c lwz r30,12(r29)
01902ab4: 2f9e0000 cmpwi cr7,r30,0
01902ab8: 419e0060 beq- cr7,0x1902B18
01902abc: 7fc3f378 mr r3,r30
01902ac0: 38800035 li r4,53
01902ac4: 48031125 bl 0x1933BE8
Fault caused by load operation

Registers pointing to code:
r5 : module Kickstart/dos.library.kmod at 0x01902AA0 (section 0 @ 0xC4C4)
r6 : module Kickstart/dos.library.kmod at 0x01902AA0 (section 0 @ 0xC4C4)
r7 : module Kickstart/kernel at 0x020A9824 (section 1 @ 0x49828)
r9 : module Kickstart/rtg.library at 0x02260000 (section 1 @ 0x5E4)
r11: module Kickstart/kernel at 0x01816CFC (section 0 @ 0x16D00)
r17: module PrefsObjectsEditor at 0x6F8C360C (section 5 @ 0x5F0)
r20: module golded:etc/plugins/textbar.api at 0x58CB0000 (section 0 @ 0x87C)
r22: module Kickstart/rtg.library at 0x02260000 (section 1 @ 0x5E4)
ip : module Kickstart/dos.library.kmod at 0x01902AB0 (section 0 @ 0xC4D4)
lr : module Kickstart/dos.library.kmod at 0x01902AA0 (section 0 @ 0xC4C4)
ctr: module Kickstart/kernel at 0x01816CFC (section 0 @ 0x16D00)

Stack Backtrace:
(0x54c11410) module Kickstart/dos.library.kmod at 0x01902AB0 (section 0 @ 0xC4D4)
(0x54c11430) module Kickstart/dos.library.kmod at 0x019364D4 (section 0 @ 0x3FEF8)
(0x54c11490) module Kickstart/dos.library.kmod at 0x01913EF8 (section 0 @ 0x1D91C)
(0x54c114b0) module PrefsObjectsEditor at 0x6F8C3978 (section 5 @ 0x95C)
(0x54c11d00) module Kickstart/newlib.library.kmod at 0x01A45F54 (section 0 @ 0x2098)
(0x54c11d70) module Kickstart/newlib.library.kmod at 0x01A46BFC (section 0 @ 0x2D40)
(0x54c11f10) module Kickstart/newlib.library.kmod at 0x01A46D78 (section 0 @ 0x2EBC)
(0x54c11f50) _start:_start()+0x170 (section 1 @ 0x170)
(0x54c11f90) module Kickstart/dos.library.kmod at 0x01918F3C (section 0 @ 0x22960)
(0x54c11fc0) module Kickstart/kernel at 0x0183BD20 (section 0 @ 0x3BD24)
(0x54c11fd0) module Kickstart/kernel at 0x0183BDA0 (section 0 @ 0x3BDA4)
(0x54c11fe0)
(0x0) module Kickstart/kernel at 0x021BDC56 (section 1 @ 0x15DC5A)
WARNING: Backchain pointer loops

Disassembly of crash site:
01902aa0: 7c7c1b79 mr. r28,r3
01902aa4: 41820074 beq- 0x1902B18
01902aa8: 57fd103b rlwinm. r29,r31,2,0,29
01902aac: 4182006c beq- 0x1902B18
>01902ab0: 83dd000c lwz r30,12(r29)
01902ab4: 2f9e0000 cmpwi cr7,r30,0
01902ab8: 419e0060 beq- cr7,0x1902B18
01902abc: 7fc3f378 mr r3,r30
01902ac0: 38800035 li r4,53
01902ac4: 48031125 bl 0x1933BE8
Stack pointer (0x54c11410) is inside bounds
Redzone is OK (4)

68k register dump
DATA: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
ADDR: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Page information:
Page not found


Task 0x56b37340 (PrefsObjectsEditor) bad access @ 0x60e1628, pc = 0x191818c, lr = 0x1918150,
Task 0x56b37340 (PrefsObjectsEditor) bad access @ 0x1b3299c, pc = 0x181257c, lr = 0x1818168,

[tonyw]

And what did you do to achieve that output?
Every command/keystroke, please.

[trixie]

@tonyw

Very simple:

- I booted into Workbench.
- Executed Memguard and Sashimi.
- Opened the SYS:Utilities drawer and clicked on the PrefsObjectsEditor icon.
- Here comes the hit.

[trixie]

So, has anyone actually tried to run MemGuard and reproduce the hit? I've recently reported MemGuard hits in SketchBlock and NetSurf - in both cases they were real (and have since been fixed by the authors) so I don't think I'm just imagining things.

[kas1e]

@Trixie

I just tests it on my latest beta / peg2, and just dbl-click on icon even bring not memguard hit, but classic GR instead !

Hidden Text - Click to Show :

Crash log for task "PrefsObjectsEditor"
Generated by GrimReaper 53.7
Crash occured in module dos.library.kmod at address 0x01930454
Type of crash: DSI (Data Storage Interrupt) exception

Register dump:
GPR (General Purpose Registers):
0: 0000000D 6660D410 00000000 667BFDC0 00000000 01930444 01930444 020A2BC8
8: 6FE21740 02260000 01963F30 0181F590 020A2BC8 68C221FC 00000000 00000000
16: 67F2D380 7F9B160C 00000000 19FD6160 68C20000 6660D8C0 02260000 00000000
24: 00000400 6660D8C0 20000000 02260000 667BFDC0 060E161C 6660D448 81838587


FPR (Floating Point Registers, NaN = Not a Number):
0: nan 162 854 0
4: 0 1114.8 45.8 0
8: 0 1 1114.8 45.8
12: 1277 900 0 0
16: 0 0 0 0
20: 0 0 0 0
24: 0 0 0 0
28: 0 0 0 0

FPSCR (Floating Point Status and Control Register): 0x82004000


SPRs (Special Purpose Registers):
Machine State (msr) : 0x0200F030
Condition (cr) : 0x48822042
Instruction Pointer (ip) : 0x01930454
Xtended Exception (xer) : 0x00000000
Count (ctr) : 0x0181F590
Link (lr) : 0x01930444
DSI Status (dsisr) : 0x40000000
Data Address (dar) : 0x060E1628



680x0 emulated registers:
DATA: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
ADDR: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
FPU0: 0 0 0 0
FPU4: 0 0 0 0



Symbol info:
Instruction pointer 0x01930454 belongs to module "dos.library.kmod" (HUNK/Kickstart)

Stack trace:
native kernel module dos.library.kmod+0x0000c874
native kernel module dos.library.kmod+0x000401c0
native kernel module dos.library.kmod+0x0001d9f8
module PrefsObjectsEditor at 0x7F9B1978 (section 5 @ 0x960)
native kernel module newlib.library.kmod+0x0000208c
native kernel module newlib.library.kmod+0x00002d34
native kernel module newlib.library.kmod+0x00002eb0
PrefsObjectsEditor:_start()+0x170 (section 1 @ 0x170)
native kernel module dos.library.kmod+0x00022a34
native kernel module kernel+0x00043fbc
native kernel module kernel+0x0004403c
module SYS:System/GrimReaper at 0x00000000 (section 0 @ 0xFFFFFFE8)

PPC disassembly:
0193044c: 57fd103b rlwinm. r29,r31,2,0,29
01930450: 4182006c beq- 0x19304BC
*01930454: 83dd000c lwz r30,12(r29)
01930458: 2f9e0000 cmpwi cr7,r30,0
0193045c: 419e0060 beq- cr7,0x19304BC

System information:

CPU
Model: Motorola MPC 7447/7457 Apollo V1.1
CPU speed: 999 MHz
FSB speed: 133 MHz
Extensions: performancemonitor altivec

Machine
Machine name: Pegasos II
Memory: 1048576 KB
Extensions: bus.pci bus.agp

Expansion buses
PCI/AGP
00:00.0 Vendor 0x11AB Device 0x6460
00:01.0 Vendor 0x1106 Device 0x3044
Range 0: 80000000 - 80000800 (MEM)
Range 1: 00001080 - 00001100 (IO)
00:0C.0 Vendor 0x1106 Device 0x8231
00:0C.1 Vendor 0x1106 Device 0x0571
Range 0: 00001000 - 00001008 (IO)
Range 1: 00001008 - 0000100C (IO)
Range 2: 00001010 - 00001018 (IO)
Range 3: 00001018 - 0000101C (IO)
Range 4: 00001020 - 00001030 (IO)
00:0C.2 Vendor 0x1106 Device 0x3038
Range 4: 00001040 - 00001060 (IO)
00:0C.3 Vendor 0x1106 Device 0x3038
Range 4: 00001060 - 00001080 (IO)
00:0C.4 Vendor 0x1106 Device 0x8235
00:0C.5 Vendor 0x1106 Device 0x3058
Range 0: 00001100 - 00001200 (IO)
Range 1: 00001030 - 00001034 (IO)
Range 2: 00001030 - 00001034 (IO)
00:0C.6 Vendor 0x1106 Device 0x3068
Range 0: 00001200 - 00001300 (IO)
00:0D.0 Vendor 0x1106 Device 0x3065
Range 0: 00001300 - 00001400 (IO)
Range 1: 80000800 - 80000900 (MEM)
01:00.0 Vendor 0x11AB Device 0x6460
01:08.0 Vendor 0x1002 Device 0x5960
Range 0: C0000000 - C8000000 (PREF.MEM)
Range 1: 00001000 - 00001100 (IO)
Range 2: C8000000 - C8010000 (MEM)
01:08.1 Vendor 0x1002 Device 0x5940
Range 0: D0000000 - D8000000 (PREF.MEM)
Range 1: C8010000 - C8020000 (MEM)

Libraries
0x69118d48: english-british.language V52.1
0x021b69a6: exec.library V53.39
0x6ff7f624: vilintuisup.library V0.9
0x6ff7f4f8: cgxvideo.library V42.1
0x6ff620e0: cybergraphics.library V43.0
0x6671d864: device.audio V6.2
0x667f0af8: SubDock.docky V53.1
0x663bccc4: filesave.audio V6.3
0x66a94570: slider.gadget V53.12
0x66a941b0: arexx.class V53.3
0x68188da0: getfont.gadget V53.9
0x66a671d0: requester.class V53.18
0x66a942f0: getfile.gadget V53.11
0x6639ece0: integer.gadget V53.10
0x6639ea60: bitmap.image V53.9
0x6639e920: space.gadget V53.6
0x6639e7e0: checkbox.gadget V53.9
0x6639e1b8: clicktab.gadget V53.40
0x663bc208: chooser.gadget V53.18
0x6639e420: penmap.image V53.5
0x6627fb94: asl.library V53.46
0x6fde7068: via-ac97.audio V5.9
0x67e3c168: listbrowser.gadget V53.52
0x66706060: string.gadget V53.17
0x6fde72f0: scroller.gadget V53.13
0x66b29714: usergroup.library V4.30
0x6815e408: emulation.library V53.1
0x681a0360: bsdsocket.library V4.307
0x68597730: mathieeedoubbas.library V52.1
0x68689f2c: textclip.library V53.1
0x6877e0bc: xadmaster.library V13.1
0x68e528b4: xpkmaster.library V5.2
0x690b8f40: button.gadget V53.15
0x687f2050: glyph.image V53.3
0x68a38dd0: window.class V53.50
0x68e508c8: popupmenu.class V53.2
0x690b3578: popupmenu.library V53.10
0x690b8ea0: label.image V53.12
0x6ff7f6d8: layout.gadget V53.19
0x68e507d0: bevel.image V53.6
0x690b8e00: drawlist.image V53.3
0x690b8d60: ilbm.datatype V53.2
0x690b8a40: png.datatype V53.7
0x6911a054: picture.datatype V53.6
0x690c964c: ft2.library V53.2
0x6ff0608c: workbench.library V53.51
0x69116c48: timezone.library V53.6
0x6911bc58: application.library V53.12
0x6fffb6cc: commodities.library V53.1
0x69103940: datatypes.library V53.4
0x690b0b10: Picasso96API.library V2.359
0x690b19f0: gadtools.library V53.4
0x690c9454: png.iconmodule V53.1
0x694968cc: icon.library V53.13
0x69118648: version.library V53.11
0x69164740: iffparse.library V53.1
0x6fdeb8cc: locale.library V53.5
0x6ff5a7ac: diskfont.library V53.5
0x6ffa4d98: petunia.library V53.4
0x6ffa4b58: diskcache.library V3.30
0x6fdbc684: dos.library V53.118
0x6ff7f9e4: usbprivate.library V53.12
0x6ff032bc: massstorage.usbfd V53.21
0x6ff03228: bootkeyboard.usbfd V52.3
0x6ff031a8: bootmouse.usbfd V53.1
0x6ff7f89c: hub.usbfd V53.10
0x6ff7f7ec: usbresource.library V53.12
0x6ff82478: hunk.library V53.4
0x6ffa4414: elf.library V53.18
0x6ff894d0: intuition.library V53.42
0x6ff3e150: rtg.library V53.30
0x6ff92920: ATIRadeon.chip V53.26
0x6ff928a4: PCIGraphics.card V53.5
0x6ffa6a10: keymap.library V53.5
0x6ff80c40: layers.library V53.7
0x6ffb4420: graphics.library V53.6
0x6ff82044: nonvolatile.library V53.5
0x6ffa7438: newlib.library V53.19
0x6ff901ac: utility.library V53.3
0x6ffa60a8: expansion.library V53.1
0x6872e58e: rexxsyslib.library V45.7 (Legacy)

Devices
0x6671f784: ppp-ethernet.device V52.4
0x66181c18: via-rhine.device V53.4
0x67e631b4: ahi.device V6.6
0x687f4854: diskimage.device V52.78
0x6ff90d10: usbsys.device V53.12
0x6ff82af0: ehci.usbhcd V53.18
0x6ff82a50: ohci.usbhcd V53.19
0x6ff829b0: uhci.usbhcd V53.13
0x6ff92c24: peg2ide.device V53.15
0x6ff90648: console.device V53.75
0x6ff913f0: ramdrive.device V52.6
0x6ffa6c5c: input.device V53.4
0x6ff5a3b4: keyboard.device V53.10
0x6ffa6774: gameport.device V52.1
0x6ff912d0: timer.device V53.1

Tasks
input.device (Waiting)
Stack: 0x6ff46000 - 0x6ff56000, pointer @ 0x6ff55f00 (Cookie OK)
Signals: SigRec 0x80000000, SigWait 0x00000000
State: Task (Waiting)
SFS DosList handler (Waiting)
Stack: 0x6fd65004 - 0x6fd67ffc, pointer @ 0x6fd67f20 (Cookie OK)
.... balblabal .....

I.e. i just run it after hard reboot and its happy crashes.

Another funny momment, that its never crashes if i run it from context menu, but crashes all the time if i run it from icon on wb. If i change in icon of prefsobjecteditor from "workbench" to "shell" , then it runs fine. So, seems something wrong with parsing of WB args or so ?

I will ask now in mailing list if anyone can reproduce, and then will make a BZ

[kas1e]

@Trixie
BZ done, #8256 with your and my crashlogs

[trixie]

@kas1e

Thank you! Now let's hope someone actually looks at what the problem might be.

[kas1e]

@Trixie

Now let's hope someone actually looks at what the problem might be.

Fixed already

[trixie]

Wow, that was quicker than a nun's first curry