Bug in listbrowser.gadget with GA_HintInfo [solved]

[blmara]

Hi! I think I found a bug with listbrowser.gadget (version 53.61 in my OS4.1.6 Amiga X1000) with WINDOW_GadgetHelp and GA_HintInfo. The gadget hint is shown properly unless both the gadget has no listbrowser nodes added and the gadget is disabled. When one moves mouse pointer over the gadget OS crashes/locks up when it should show the hint.

I modified the SDK:examples/Reaction/os4examples/LB_Example adding WINDOW_GadgetHelp to Window and GA_HintInfo & GA_Disabled,TRUE to the listbrowser and commented out adding the contents to listbrowser to show the crash/lockup.

Bug, isn't it?

Marko

Code: Select all

;/* Execute me to compile
gcc -o LB_Example LB_Example.c -lauto
quit
;*/

#include <proto/intuition.h>
#include <proto/graphics.h>
#include <proto/exec.h>
#include <proto/dos.h>
#include <proto/icon.h>
#include <proto/listbrowser.h>

#include <classes/window.h>
#include <gadgets/layout.h>
#include <gadgets/listbrowser.h>
#include <images/glyph.h>
#include <images/label.h>
#include <libraries/gadtools.h>


ULONG lb_hook(struct Hook *hook, struct Node *node, struct LBDrawMsg *msg);

struct TextAttr emerald17 = { (STRPTR)"emerald.font", 18, FS_NORMAL, 0x01 };


/* Here's where it all starts. */
main()
{
	struct Screen *screen = NULL;

	/* We'll just open up on the default public screen, and use its screen font. */
	if (screen = IIntuition->LockPubScreen(NULL))
	{
	struct TextAttr emerald17 = { (STRPTR)"emerald.font", 18, FS_NORMAL, 0x01 };
	struct DrawInfo *drinfo = IIntuition->GetScreenDrawInfo(screen);
	Object *layout;
	Object *lb_gad;
	struct Node *node;
	Object *limage;
	Object *gimage;
	struct Hook lbhook;

	struct List list;
	IExec->NewList(&list);

	struct ColumnInfo *ci = IListBrowser->AllocLBColumnInfo(1,
	LBCIA_Column, 0,
	LBCIA_Title, "Column Header",
	LBCIA_Width, 100,
	TAG_DONE);

	if (layout = IIntuition->NewObject(NULL, "layout.gadget",
	GA_DrawInfo, drinfo,
	LAYOUT_DeferLayout, TRUE,	/* Layout refreshes done on
	 * task's context (by the
	 * window class) */
	LAYOUT_SpaceOuter, TRUE,
	LAYOUT_AddChild, lb_gad = IIntuition->NewObject(NULL, "listbrowser.gadget",
	GA_ID, 1,
	GA_RelVerify, TRUE,
                                                        GA_HintInfo,"Hello to all!",
                                                        GA_Disabled,TRUE,
	LISTBROWSER_ColumnInfo, ci,
	LISTBROWSER_ColumnTitles, TRUE,
	LISTBROWSER_Separators, TRUE,
	LISTBROWSER_Hierarchical, TRUE,
	LISTBROWSER_Editable, TRUE,
	LISTBROWSER_MultiSelect, TRUE,
	LISTBROWSER_ShowSelected, TRUE,
	TAG_DONE),

	TAG_DONE))
	{
	struct MsgPort *app_port;
	Object *window_obj;

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Demo of ListBrowserNode features",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Editable node",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Click twice to edit",
	LBNCA_Editable, TRUE,
	LBNCA_MaxChars, 60,
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Change colours",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Flags, LBFLG_CUSTOMPENS,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Colourful!",
	LBNCA_FGPen, 19,
	LBNCA_BGPen, 18,
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Checkbox item",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_CheckBox, TRUE,
	LBNA_Checked, TRUE,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Checked by default",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_CheckBox, TRUE,
	LBNA_Checked, FALSE,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Unchecked by default",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Justifications",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Left",
	LBNCA_Justification, LCJ_LEFT,
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Centre",
	LBNCA_Justification, LCJ_CENTRE,
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Right",
	LBNCA_Justification, LCJ_RIGHT,
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Read-Only node",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Flags, LBFLG_READONLY,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Can't select me!",
	TAG_DONE))
	IExec->AddTail( &list, node );

	gimage = IIntuition->NewObject(NULL, "glyph.image",
	IA_Width, 20,
	IA_Height, 20,
	GLYPH_Glyph, GLYPH_POPTIME,
	TAG_DONE);
	limage = IIntuition->NewObject(NULL, "label.image",
	IA_Font, &emerald17,
	LABEL_Text, "Created using _label.image\n",
	IA_Font, screen->Font,
	LABEL_SoftStyle, FSF_BOLD | FSF_ITALIC,
	LABEL_Image, gimage,
	IA_FGPen, 35,
	LABEL_Text, " Cool eh?",
	TAG_DONE);

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Some images",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_Image, limage,
	TAG_DONE))
	IExec->AddTail( &list, node );

	lbhook.h_Entry = (ULONG (*)())lb_hook;
	lbhook.h_SubEntry = NULL;
	lbhook.h_Data = NULL;

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 1,
	LBNA_Flags, LBFLG_HASCHILDREN | LBFLG_SHOWCHILDREN,
	LBNA_Column, 0,
	LBNCA_CopyText, TRUE,
	LBNCA_Text, "Rendering hook",
	TAG_DONE))
	IExec->AddTail( &list, node );

	if (node = IListBrowser->AllocListBrowserNode(1,
	LBNA_Generation, 2,
	LBNA_Column, 0,
	LBNCA_RenderHook, &lbhook,
	LBNCA_HookHeight, 20,
	TAG_DONE))
	IExec->AddTail( &list, node );

	/* Create a message port for App* messages.  This is needed for
	 * iconification.  We're being a touch naughty by not checking
	 * the return code, but that just means that iconification won't
	 * work, nothing really bad will happen.
	 */
	app_port = IExec->CreateMsgPort();

	/* Create the window object. */
	if (window_obj = IIntuition->NewObject(NULL, "window.class",
	WA_Left, 0,
	WA_Top, screen->Font->ta_YSize + 3,
	WA_CustomScreen, screen,
	WA_IDCMP, IDCMP_CLOSEWINDOW | IDCMP_REFRESHWINDOW,
	WA_Flags, WFLG_DRAGBAR | WFLG_DEPTHGADGET | WFLG_CLOSEGADGET |
	WFLG_SIZEGADGET | WFLG_ACTIVATE | WFLG_SMART_REFRESH,
	WA_Title, "ReAction ListBrowser class example",
	WA_InnerWidth, 300,
	WA_InnerHeight, 200,
	WA_NewLookMenus, TRUE,
	WINDOW_GadgetHelp,TRUE,
	WINDOW_ParentGroup, layout,
	WINDOW_IconifyGadget, TRUE,
	WINDOW_Icon, IIcon->GetDiskObject("PROGDIR:LB_Example"),
	WINDOW_IconTitle, "LB_Example",
	WINDOW_AppPort, app_port,
	TAG_DONE))
	{
	struct Window *win;

	/*  Open the window. */
	if (win = (struct Window *)IIntuition->IDoMethod(window_obj, WM_OPEN))
	{
	ULONG signal;
	BOOL ok = TRUE;

	/* add the labels to the listbrowser */
	//IIntuition->SetGadgetAttrs((struct Gadget*)lb_gad, win, NULL, LISTBROWSER_Labels, &list, TAG_DONE );

	/* Obtain the window wait signal mask.*/
	IIntuition->GetAttr(WINDOW_SigMask, window_obj, &signal);

	/* Input Event Loop */
	while (ok)
	{
	ULONG result;

	IExec->Wait(signal | (1L << app_port->mp_SigBit));

	/* WM_HANDLEINPUT returns the gadget ID of a clicked
	 * gadget, or one of several pre-defined values.  For
	 * this demo, we're only actually interested in a
	 * close window and a couple of gadget clicks.
	 */
	int16 code = 0;
	while ((result = IIntuition->IDoMethod(window_obj, WM_HANDLEINPUT, &code)) != WMHI_LASTMSG)
	{
	switch(result & WMHI_CLASSMASK)
	{
	case WMHI_CLOSEWINDOW:
	ok = FALSE;
	break;

	case WMHI_GADGETUP:
	switch (result & WMHI_GADGETMASK)
	{
	default:
	break;
	}
	break;

	case WMHI_ICONIFY:
	if (IIntuition->IDoMethod(window_obj, WM_ICONIFY))
	win = NULL;
	break;

	case WMHI_UNICONIFY:
	win = (struct Window*)IIntuition->IDoMethod(window_obj, WM_OPEN);
	break;

	default:
	break;
	}
	}
	}
 	}
	else
	IDOS->PutStr("ERROR: failed to start.  Couldn't open window\n");

	/* Disposing of the window object will also close the
	 * window if it is already opened and it will dispose of
	 * all objects attached to it.
	 */
	IIntuition->DisposeObject(window_obj);
	IListBrowser->FreeLBColumnInfo(ci);
	}
	else
	IDOS->PutStr("ERROR: failed to start.  Couldn't create window\n");

	/* Lose the App* message port. */
	if (app_port)
	IExec->DeleteMsgPort(app_port);
	}
	else
	IDOS->PutStr("ERROR: failed to start.  Couldn't create layout\n");

	if (drinfo)
	IIntuition->FreeScreenDrawInfo(screen, drinfo);

	    IIntuition->UnlockPubScreen(0, screen);
	}
	else
	IDOS->PutStr("ERROR: failed to start.  Couldn't lock destination screen\n");

	return(0);
}

ULONG lb_hook(struct Hook *hook, struct Node *node, struct LBDrawMsg *msg)
{
	UWORD patterndata[2] = { 0x2222, 0x8888 };
	WORD width = msg->lbdm_Bounds.MaxX - msg->lbdm_Bounds.MinX;
	WORD height = msg->lbdm_Bounds.MaxY - msg->lbdm_Bounds.MinY;

    if(msg->lbdm_MethodID != LV_DRAW)
        return(LBCB_UNKNOWN);

	IGraphics->SetAPen(msg->lbdm_RastPort, 69);
	IGraphics->DrawEllipse(msg->lbdm_RastPort,
	msg->lbdm_Bounds.MinX + (width / 2), msg->lbdm_Bounds.MinY + (height / 2),
	width / 2, height / 2);

    return(LVCB_OK);
}

[LyleHaze]

Hi! I think I found a bug with listbrowser.gadget (version 53.61 in my OS4.1.6 Amiga X1000) with WINDOW_GadgetHelp and GA_HintInfo. The gadget hint is shown properly unless both the gadget has no listbrowser nodes added and the gadget is disabled. When one moves mouse pointer over the gadget OS crashes/locks up when it should show the hint.

I modified the SDK:examples/Reaction/os4examples/LB_Example adding WINDOW_GadgetHelp to Window and GA_HintInfo & GA_Disabled,TRUE to the listbrowser and commented out adding the contents to listbrowser to show the crash/lockup.

Bug, isn't it?

LISTBROWSER_Labels (struct List *)
An Exec list. Nodes in this list must be allocated with
AllocListBrowserNodeA().

A value of ~0 or NULL indicates that the list is "detached".
This must be done before you can modify a list already attached
to a list browser. After detaching, you should carry out your
updates to the list as quickly as possibly and then re-attach.
When a list browser is initially added to a window it must have
a list attached to it, NULL is not valid in this case.

So by opening it without a list attached you have ignored the conditions of use. And by keeping the list detached have done so again.

[edit] the original example code attaches the list right AFTER calling the WM_Open method, which appears to also be in
conflict with the listbrowser autodoc. Perhaps not the best example of following the rules?
In any case there's not much re-arranging needed to put the listbrowser nodes into the list first, then add a tag like
LISTBROWSER_Labels, &list,
when the listbrowser is actually being created. This way it has a populated list when it is first opened. Then it's just up to
the programmer to unattach the list briefly when making changes, and to be careful to re-attach it as quickly as possible
after the changes have been made.

Have Fun!
LyleHaze

[blmara]

Hi! I think I found a bug with listbrowser.gadget (version 53.61 in my OS4.1.6 Amiga X1000) with WINDOW_GadgetHelp and GA_HintInfo. The gadget hint is shown properly unless both the gadget has no listbrowser nodes added and the gadget is disabled. When one moves mouse pointer over the gadget OS crashes/locks up when it should show the hint.

I modified the SDK:examples/Reaction/os4examples/LB_Example adding WINDOW_GadgetHelp to Window and GA_HintInfo & GA_Disabled,TRUE to the listbrowser and commented out adding the contents to listbrowser to show the crash/lockup.

Bug, isn't it?

LISTBROWSER_Labels (struct List *)
An Exec list. Nodes in this list must be allocated with
AllocListBrowserNodeA().

A value of ~0 or NULL indicates that the list is "detached".
This must be done before you can modify a list already attached
to a list browser. After detaching, you should carry out your
updates to the list as quickly as possibly and then re-attach.
When a list browser is initially added to a window it must have
a list attached to it, NULL is not valid in this case.

So by opening it with an empty list you have ignored the conditions of use. And by keeping the list empty have done so again.

Have Fun!
LyleHaze

Really, that did the trick! Attaching an initialized (IExec->NewList()) list with no nodes works and doesn't crash anymore. Thanks! One should read the autodocs carefully...

MArko

[LyleHaze]

Really, that did the trick! Attaching an initialized (IExec->NewList()) list with no nodes works and doesn't crash anymore. Thanks! One should read the autodocs carefully...

MArko

I am happy if I can help.

I keep the autodocs open any time I am coding. Programs like "AutodocViewer" by Glenn Hisdal or SDKBrowser by BitByBit software are indispensable.

If you allocate lists with IExec->AllocSysObject(ASOT_LIST, TAG_END), you don't even need to NewList() them.

But that's another subject for another day.

Have Fun!

[Rigo]

Confirmed, and fixed internally.

Thanks for the report.

Simon