URL PRefs' "reset to defaults" menu item obliterates the user's preferences without asking.
To reproduce:
1. Open URL PRefs
2. Add an extra entry called TEST
3. Click Save
4. Re-open URL Prefs and verify the TEST entry is still present
5. Select "Reset to defaults" from the "Edit" menu
6. Note the TEST entry disappears as it should
7. Click CANCEL
8. Re-open URL Prefs. Note that the TEST entry has not re-appeared and even "Last saved" does not bring it back.
URL Prefs overwrites the user's saved and current configuration when selecting "reset to defaults" rather than waiting for the settings to be saved or used.
On further investigation what it does is immediately DELETES the configuration from ENV: and ENVARC:. There is also no "Use" button on the GUI, which is non-standard, and as it uses the standard ENV/ENVARC setup I don't see why this is missing?
URL Prefs' "reset to defaults" broken
- colinw
- AmigaOS Core Developer
- Posts: 218
- Joined: Mon Aug 15, 2011 10:20 am
- Location: Brisbane, QLD. Australia.
Re: URL Prefs' "reset to defaults" broken
The act of selecting the menu "Reset To Defaults" performs the action, just the same as selecting "SnapShot" from the workbench
menu actually does the action requested.
Clicking "Cancel" to exit, actually cancelled any edits to the new reset configuration, and not cancelling the defaults config reset itself.
menu actually does the action requested.
Clicking "Cancel" to exit, actually cancelled any edits to the new reset configuration, and not cancelling the defaults config reset itself.
Re: URL Prefs' "reset to defaults" broken
I figured that, but it isn't how any of the other prefs editors work (even Last saved and Restore within URL prefs don't appear to operate like that). Likewise the lack of a "Use" button.colinw wrote:The act of selecting the menu "Reset To Defaults" performs the action, just the same as selecting "SnapShot" from the workbench
menu actually does the action requested.
Clicking "Cancel" to exit, actually cancelled any edits to the new reset configuration, and not cancelling the defaults config reset itself.
Try the same test with Pointer Prefs and you'll see what I mean.
- colinw
- AmigaOS Core Developer
- Posts: 218
- Joined: Mon Aug 15, 2011 10:20 am
- Location: Brisbane, QLD. Australia.
Re: URL Prefs' "reset to defaults" broken
For the URL prefs, I don't know what the author implemented for the "Last Saved" or "Restore" options.chris wrote: ...
I figured that, but it isn't how any of the other prefs editors work (even Last saved and Restore within URL prefs don't appear to operate like that). Likewise the lack of a "Use" button. Try the same test with Pointer Prefs and you'll see what I mean.
You may care to file an exhancement/bug report for those additions/changes, so they perform as expected.
Re: URL Prefs' "reset to defaults" broken
Would love to, but I can't. That was the reason I'm posting about this here.colinw wrote:You may care to file an exhancement/bug report for those additions/changes, so they perform as expected.