Support Forum
https://forum.hyperion-entertainment.com/
https://forum.hyperion-entertainment.com/viewtopic.php?t=582
Code: Select all
typedef unsigned char UBYTE; /* unsigned 8-bit quantity */
UBYTE is always unsigned while char without signed or unsigned keyword can be either signed or unsigned depending on the compiler, the target system and what compiler options are used (f.e. gcc allows to force either signed or unsigned with -fsigned-char and -funsigned-char options).JosDuchIt wrote:Are char and UBYTE interchangeable types ?
- if no what is the difference?
Use casts.JosDuchIt wrote:- if yes how get rid of those warnings complaining about signedness? (in an easy way)
i'lll try that first as easy solution. There must be hundreds of signedness complaints in the source i am working on (gcview - btw it compiles and works allready better than the 68k version under OS4) so casts were in my mind the hard solution. I guess i'll use the gcc option giving me the least signedness complaints and standardise(using casts) on that definition of char.gcc allows to force either signed or unsigned with -fsigned-char and -funsigned-char options).
Code: Select all
struct Picture // every picture gets one ///was Picture
{
UBYTE path[260];
UBYTE alias[40]; // the given name of this picture
}
struct Picture *getpic (char *name, char *alias, struct Base *bs, SHORT mode)
{
struct Picture *pic, *bpic;
stccpy (pic->path, name, 255);
stccpy (pic->alias, strupr(alias), 35);
}
size_t stccpy (
char * dest,
const char * src,
size_t n)
{
char * ptr = dest;
while (n>1 && *src)
{
*ptr = *src;
ptr ++;
src ++;
n--;
}
*ptr++ = '\0';
return (ptr-dest);
}
Code: Select all
stccpy (pic->path, (UBYTE *)name, 255);
stccpy (pic->alias, (UBYTE *)strupr(alias), 35); A cast changes the type of the pointer, not the type of the function argument. If you have a pointer to UBYTE and a function which needs char, you need to cast to char, not the other way around.JosDuchIt wrote:but with the castsI expected to get rid of the warning both in the case 2) and 3) ??Code: Select all
stccpy (pic->path, (UBYTE *)name, 255); stccpy (pic->alias, (UBYTE *)strupr(alias), 35);
Code: Select all
stccpy ((char *)pic->path, name, 255);
stccpy ((char *)pic->alias, strupr(alias), 35); Better use TEXT type here instead of UBYTE. For string pointers you should use STRPTR (CONST_STRPTR for a constant string).JosDuchIt wrote:Code: Select all
struct Picture // every picture gets one ///was Picture { UBYTE path[260]; UBYTE alias[40]; // the given name of this picture }
Code: Select all
stccpy ((char *)pic->path, (const char *)name, 255);
stccpy ((char *)pic->alias, (const char *)strupr(alias), 35);