Hyperion Entertainment Message Boards

Amiguy wrote: Mon Nov 08, 2021 11:44 am An idea ?

On Thu, Nov 04, 2021 at 02:42:49PM -0700, Vivek Kasireddy wrote:
> When virgl is not enabled, vfpriv pointer would not be allocated.
> Therefore, check for a valid value before dereferencing.
>
> Reported-by: Christian Zigotzky <[email protected]>
> Cc: Gurchetan Singh <[email protected]>
> Cc: Gerd Hoffmann <[email protected]>
> Signed-off-by: Vivek Kasireddy <[email protected]>
> ---
> drivers/gpu/drm/virtio/virtgpu_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
> index 749db18dcfa2..d86e1ad4a972 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
> @@ -163,10 +163,11 @@ static __poll_t virtio_gpu_poll(struct file *filp,
> struct drm_file *drm_file = filp->private_data;
> struct virtio_gpu_fpriv *vfpriv = drm_file->driver_priv;
> struct drm_device *dev = drm_file->minor->dev;
> + struct virtio_gpu_device *vgdev = dev->dev_private;
> struct drm_pending_event *e = NULL;
> __poll_t mask = 0;
>
> - if (!vfpriv->ring_idx_mask)
> + if (!vgdev->has_virgl_3d || !vfpriv || !vfpriv->ring_idx_mask)
> return drm_poll(filp, wait);
>
> poll_wait(filp, &drm_file->event_wait, wait);

Pushed to drm-misc-next-fixes.

thanks,
Gerd

• X5000: fsl_booke patch because of the boot issue (only alpha5):
  • New kernels -- forum.hyperion-entertainment.com
  • [FSL P50x0] Cyrus+ board doesn't boot with the PowerPC updates 5.16-1 -- linuxppc-dev mailing list
• PowerPC updates 5.16-1
• Enabled STRICT_KERNEL_RWX for Freescale 85xx platforms
• Fixed boot hangs on e5500 due to stale value in ESR passed to do_page_fault()
• pasemi_defconfig: CONFIG_PPC_64K_PAGES=y removed
• Nintendo Switch Controller Driver, Sony PS5 Controller Improvements Come For Linux 5.16 -- phoronix.com
• Nintendo Joy-Con and Pro Controller support (HID_NINTENDO) as kernel module
• Nintendo Switch controller force feedback support (NINTENDO_FF)
• Nintendo Wii and Wii U Bluetooth peripherals support (HID_WIIMOTE) as kernel module (Supported devices are the Wii Remote and its extension devices, but also devices based on the Wii Remote like the Wii U Pro Controller or the Wii Balance Board)
• Linux Git log
• Phoronix articles, reviews and news stories covering Linux 5.16

Skateman wrote: Wed Nov 10, 2021 8:43 am Kernel 5.16 Alpha 5 up and running fine on my AmigaOne X5000

kilaueabart wrote: Wed Nov 10, 2021 11:14 pm By golly, 16a5 seems to work here too!

• X1000: ata patch because of the issue with detecting of ATA disks. Further information:
  • New kernels X1000 thread
  • [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates
• X1000: big refactoring of the PASEMI i2c driver to support the Apple M1. Further information:
  • Kernel 5.15 X1000 thread
  • i2c updates
• Linux Git log
• Phoronix articles, reviews and news stories covering Linux 5.16