GUI improvement we need

A forum for general AmigaOS 4.x support questions that are not platform-specific
User avatar
samo79
Posts: 552
Joined: Fri Jun 17, 2011 11:13 pm
Location: Italy

GUI improvement we need

Post by samo79 »

I report here some graphics problem that still afflict NetSurf since beginning, to be able to handle (and fix) them.
I reported here because ChrisY need some help from the OS4 developers, aka certain improvement from the operative system side first

Check this grab:

http://imageshack.us/photo/my-images/853/guibugs.jpg/

We have this problems (reported by Chris):

1. Button images with alpha transparency continually overprint instead of
blanking the button and then printing.

2. Button next to tab group gets clipped when it shouldn't (this seems to
only happen at certain sizes)

3. scrollergclass in bottom window border does not react correctly when
resized (I have a half-written test case for this, but none of the resizing
code is in yet). Resize is done manually through RefreshSetGadgets, same
as the frbuttonclass/frameiclass gadget to the left of it which does resize
correctly

chris
Posts: 552
Joined: Sat Jun 18, 2011 11:05 am
Contact:

Re: GUI improvement we need

Post by chris »


User avatar
samo79
Posts: 552
Joined: Fri Jun 17, 2011 11:13 pm
Location: Italy

Re: GUI improvement we need

Post by samo79 »

And just to add, here the most annoying problems in GUI:

http://imageshack.us/photo/my-images/217/bug2u.png/
Here we have two problems (one of this related to the sidebar was already explained very well by Chris)

http://imageshack.us/photo/my-images/819/bug3s.png/
This one show the addtab button problems (if you opened some tabs the addtab button will be cutted at some point)

http://imageshack.us/photo/my-images/803/bug4.png/
Same issues

At the end i think Reaction as a framework it's "too young" and requires much more work and extreme testing before becoming mature enough to be able to handle very complex interfaces

User avatar
Rigo
AmigaOS Core Developer
AmigaOS Core Developer
Posts: 346
Joined: Mon Jan 17, 2011 9:42 pm

Re: GUI improvement we need

Post by Rigo »

I haven't been able to reproduce any of these problems with the latest NetSurf and an uptodate beta installation of OS4. I suggest you wait until Update 3 is released before reporting any further problems.

Simon

User avatar
samo79
Posts: 552
Joined: Fri Jun 17, 2011 11:13 pm
Location: Italy

Re: GUI improvement we need

Post by samo79 »

@Rigo

I understand correctly ? Did you mean you can't be able to reproduce any of that graphic issues on NetSurf 2.7 using it on the Update 3 ?

- Did you try to resize (maybe at minimum) the NetSurf window and look at it ?
- Did you test deeply the sidebar on the bottom ?
- If you open many tabs the "addtab" button remain showed correctly (as the one on Reaction OWB) ?

Sorry for such idiot questions but it seems a bit strange to me that all working fine on your machine without any "collateral" fix from Chris, but if so, well that's great for sure ;)

User avatar
Rigo
AmigaOS Core Developer
AmigaOS Core Developer
Posts: 346
Joined: Mon Jan 17, 2011 9:42 pm

Re: GUI improvement we need

Post by Rigo »

Well, after a bit more testing, it appears that the scroller in the bottom border is still affected. After a very quick look at the sources, it looks like it's not the scrollergclass, as it doesn't check for SIZEVERIFY, so the data that comes in to its Layout code must be at fault. Just what calls it is another matter, and one that is ideally suited to Massimo.

As for the other problems, no, I cannot reproduce those.

Simon

User avatar
samo79
Posts: 552
Joined: Fri Jun 17, 2011 11:13 pm
Location: Italy

Re: GUI improvement we need

Post by samo79 »

Ok i will mail him very soon, thanks for the test ;-)

P.S.
It's very good to know that all others are already fixed ! 8-)

chris
Posts: 552
Joined: Sat Jun 18, 2011 11:05 am
Contact:

Re: GUI improvement we need

Post by chris »

samo79 wrote:It's very good to know that all others are already fixed ! 8-)
Sadly a very quick test with Update 3 reveals that they aren't, or at least the fixes didn't make it into the update :-(

User avatar
samo79
Posts: 552
Joined: Fri Jun 17, 2011 11:13 pm
Location: Italy

Re: GUI improvement we need

Post by samo79 »

:|

User avatar
Rigo
AmigaOS Core Developer
AmigaOS Core Developer
Posts: 346
Joined: Mon Jan 17, 2011 9:42 pm

Re: GUI improvement we need

Post by Rigo »

Well, the first one is an easy fix, as the button is probably being redrawn with RefreshSetGadgetAttrs() which is forcing a refresh when one isn't needed. Simply use SetGadgetAttrs() on buttons that contain an image to sort out the double refresh problem. As for the others, I can't really do any more without looking at how the code sets up these gadgets.

Simon

Post Reply