RAWBInfo 53.19 ahs the same keyboard shortcut for the "Drawer" Tab and the "Write" protection bit.
Also the "Name" Textgadget has no keyboard shortcut, but is activated when pressing the "w" key if it is a drawer info-window , by pressing "f" if it is a file-info-window and by pressing "d" if it is a device-info-window.
Maybe it's just me, but for the sake of consistency I would choose the same key to do the same action, at least within one and the same executable.
As a side thought, it woudl be nice if all keyboard shortcuts for actions which are saved to disk (or distructive actions), and have no undo-function available, were only activated by a two-key shortcut.
E.g. save, should be "RAmiga+s" not only "s" like in RAWBInfo. Maybe it's an idea for the styleguide?
RAWBInfo and Keyboard Shortcuts
Re: RAWBInfo and Keyboard Shortcuts
On the Amiga, a gadget shortcut key is one of the letters in the gadget. A programmer designates the keyboard shortcut for a gadget by preceeding one of the letters by a dash. For example, _icon would make the shortcut ' i ' and ic_on would make the shortcut ' o '. Since "Drawer", "File" and "Disk" do not have a letter that occurs in all 3 names, I don't think you could have the same shortcut for all 3 of them.Amigo1 wrote:RAWBInfo 53.19 ahs the same keyboard shortcut for the "Drawer" Tab and the "Write" protection bit.
Also the "Name" Textgadget has no keyboard shortcut, but is activated when pressing the "w" key if it is a drawer info-window , by pressing "f" if it is a file-info-window and by pressing "d" if it is a device-info-window.
Maybe it's just me, but for the sake of consistency I would choose the same key to do the same action, at least within one and the same executable.
Localization can also affect the keyboard shortcuts. An English name might have completely different letters than a German or Italian translation of the English name. For example if the English name is "build" and in another language the translated name is "zopek", the keyboard shortcuts would need to be different for those 2 languages.
RAmiga is used for menu shortcuts and gadget shortcuts are a single letter. It's just how Amiga has always worked as far as I know. In the case of RAWBInfo, RAmiga+s is the menu shortcut for save already. It might be a good idea for destructive functions to bring up a confirmation requester though.As a side thought, it would be nice if all keyboard shortcuts for actions which are saved to disk (or distructive actions), and have no undo-function available, were only activated by a two-key shortcut.
E.g. save, should be "RAmiga+s" not only "s" like in RAWBInfo. Maybe it's an idea for the styleguide?
AmigaOne X1000 with 2GB memory - OS4.1 FE
- nbache
- Beta Tester
- Posts: 1714
- Joined: Mon Dec 20, 2010 7:25 pm
- Location: Copenhagen, Denmark
- Contact:
Re: RAWBInfo and Keyboard Shortcuts
Confirmed and added to Bugzilla - thanks for reporting!Amigo1 wrote:RAWBInfo 53.19 ahs the same keyboard shortcut for the "Drawer" Tab and the "Write" protection bit.
Best regards,
Niels
Re: RAWBInfo and Keyboard Shortcuts
Although I knew already, thanks for the infoxenic wrote: On the Amiga, a gadget shortcut key is one of the letters in the gadget. A programmer designates the keyboard shortcut for a gadget by preceeding one of the letters by a dash. For example, _icon would make the shortcut ' i ' and ic_on would make the shortcut ' o '.
If you set your system language to english, you can try it yourself. Call the info window of a file, tool, drawer or disk and change to the "icon" tab first. Then use the appropriate keyboard shortcut to go to the "main, first tab" (File,Drawer or Disk) and press the same key again. The "name" text-gadget will then activate and you could change the name of the file/Drawer/Disk. So you have 3 different keyboard shortcuts activating the "Name Text field gadget" but no hint to this shortcut anywhere. Kind of a hidden feature..Since "Drawer", "File" and "Disk" do not have a letter that occurs in all 3 names, I don't think you could have the same shortcut for all 3 of them.
Good point here, I forgot to mention I'm using english as the first language in Locale Prefs .Localization can also affect the keyboard shortcuts. An English name might have completely different letters than a German or Italian translation of the English name. For example if the English name is "build" and in another language the translated name is "zopek", the keyboard shortcuts would need to be different for those 2 languages.
Yes, you are right, since one could press "s" (but the shortcut without RAmiga) by accident and save changes he/she did not want to change, with no possibility to roll back (as he might have or not clumsy hands and be unaware he might have changed something).RAmiga is used for menu shortcuts and gadget shortcuts are a single letter. It's just how Amiga has always worked as far as I know. In the case of RAWBInfo, RAmiga+s is the menu shortcut for save already. It might be a good idea for destructive functions to bring up a confirmation requester though.As a side thought, it would be nice if all keyboard shortcuts for actions which are saved to disk (or distructive actions), and have no undo-function available, were only activated by a two-key shortcut.
E.g. save, should be "RAmiga+s" not only "s" like in RAWBInfo. Maybe it's an idea for the styleguide?
Re: RAWBInfo and Keyboard Shortcuts
Thank you very much!nbache wrote:Confirmed and added to Bugzilla - thanks for reporting!Amigo1 wrote:RAWBInfo 53.19 ahs the same keyboard shortcut for the "Drawer" Tab and the "Write" protection bit.
Best regards,
Niels
- broadblues
- AmigaOS Core Developer
- Posts: 600
- Joined: Sat Jun 18, 2011 2:40 am
- Location: Portsmouth, UK
- Contact:
Re: RAWBInfo and Keyboard Shortcuts
Actually that is ( actually was, as now fixed) a bug in the clicktab gadget. The click tab short cut is not supoposed to activate any gadget in the page attached to it.f you set your system language to english, you can try it yourself. Call the info window of a file, tool, drawer or disk and change to the "icon" tab first. Then use the appropriate keyboard shortcut to go to the "main, first tab" (File,Drawer or Disk) and press the same key again. The "name" text-gadget will then activate and you could change the name of the file/Drawer/Disk. So you have 3 different keyboard shortcuts activating the "Name Text field gadget" but no hint to this shortcut anywhere. Kind of a hidden feature..
Re: RAWBInfo and Keyboard Shortcuts
@broadblues
Oh I'm so glad this weirdness finally got fixed!!! I complained about it a few years ago and got the usual answer: "it's not a bug, it's a feature"broadblues wrote:Actually that is ( actually was, as now fixed) a bug in the clicktab gadget. The click tab short cut is not supoposed to activate any gadget in the page attached to it.
The Rear Window blog
AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition
AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition
Re: RAWBInfo and Keyboard Shortcuts
Thanks for fixing it!broadblues wrote:Actually that is ( actually was, as now fixed) a bug in the clicktab gadget. The click tab short cut is not supoposed to activate any gadget in the page attached to it.f you set your system language to english, you can try it yourself. Call the info window of a file, tool, drawer or disk and change to the "icon" tab first. Then use the appropriate keyboard shortcut to go to the "main, first tab" (File,Drawer or Disk) and press the same key again. The "name" text-gadget will then activate and you could change the name of the file/Drawer/Disk. So you have 3 different keyboard shortcuts activating the "Name Text field gadget" but no hint to this shortcut anywhere. Kind of a hidden feature..
- nbache
- Beta Tester
- Posts: 1714
- Joined: Mon Dec 20, 2010 7:25 pm
- Location: Copenhagen, Denmark
- Contact:
Re: RAWBInfo and Keyboard Shortcuts
Actually, in a way it was - at least you could say it might be practical to be able to switch to a tab and activate its first gadget (which in many cases is the most important one) by tapping the same key twice.trixie wrote:I complained about it a few years ago and got the usual answer: "it's not a bug, it's a feature"
But I agree that it was at best a weird and unintuitive behaviour, so good riddance . I haven't missed it at all since it was fixed in beta, at least.
Best regards,
Niels
Re: RAWBInfo and Keyboard Shortcuts
@nbache
I know. The explanation I got back then was that the tab shortcut will enable the activation of the first gadget in the layout even in situations where this gadget has no activation key set. But from the viewpoint of GUI design, this thinking is seriously flawed:at least you could say it might be practical to be able to switch to a tab and activate its first gadget (which in many cases is the most important one) by tapping the same key twice.
- first, the key shortcut belongs to the clicktab (this is visually indicated by the underscore in the tab text), not to the first gadget in the layout;
- second, the fact that a single hotkey can actually control two GUI elements is - to put it mildly - rather unusual;
- third, there can be a very good reason why the activation key is not provided for the first layout gadget; the clicktab hotkey would then override what the programmer has designed in the GUI.
The Rear Window blog
AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition
AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition