Page 1 of 5

Bug in Multiview Search requester

Posted: Wed Sep 16, 2015 7:03 am
by Steady
AmigaOS 4.1 FE on SAM 460CR
==========================

Multiview: 53.8
datatypes.library: 53.4
text.datatype: 53.8
=================

I think there is a bug (unterminated string) in the "Find ... " command where it adds trailing garbage characters to subsequent searches (i.e. find, then find again). I encountered the bug when searching the autodocs so I was using the text datatype. The bug may not be restricted to that situation but I almost always see it when doing that.

Replication Steps
===============
1) Open a text file with MultiView.
2) Press <RAmiga>-F to find.
3) Enter text to search for.
4) Press <Return> to execute search.
5) Press <RAmiga>-F to find again.
6) You will probably see the garbage at the tail end of the text. If you don't see the garbage, just repeat step 4 & 5 again until you do.

Cheers,
Jason.

Re: Bug in Multiview Search requester

Posted: Wed Sep 16, 2015 12:41 pm
by broadblues
Reproduced this just once after a great deal of repeating.

The requester comes from text.datatype, not multiview itself so I'll check for and raise a bug report against text.datatype

Re: Bug in Multiview Search requester

Posted: Wed Sep 16, 2015 12:48 pm
by broadblues
reported as bug 9302

Re: Bug in Multiview Search requester

Posted: Thu Sep 17, 2015 1:50 am
by Steady
broadblues wrote:reported as bug 9302
Thanks. I knew it was one of those things that show up at random, but I got it more often than not. Thanks for confirming and raising.

Re: Bug in Multiview Search requester

Posted: Thu Sep 17, 2015 2:56 pm
by xenic
Steady wrote:
broadblues wrote:reported as bug 9302
Thanks. I knew it was one of those things that show up at random, but I got it more often than not. Thanks for confirming and raising.
Since you would normally use <RAmiga>-N (find next) after the first search, most people would never see this bug. It's always a good idea to fix things that aren't working right though.

Re: Bug in Multiview Search requester

Posted: Fri Sep 18, 2015 11:03 am
by chris
xenic wrote:
Steady wrote:
broadblues wrote:reported as bug 9302
Thanks. I knew it was one of those things that show up at random, but I got it more often than not. Thanks for confirming and raising.
Since you would normally use <RAmiga>-N (find next) after the first search, most people would never see this bug. It's always a good idea to fix things that aren't working right though.
I always hit enter twice to do a find next in Multiview. Never realised there was a shortcut for it! Consequently I've seen this bug for years but managed to never report it.

Re: Bug in Multiview Search requester

Posted: Fri Sep 18, 2015 2:32 pm
by trixie
Since you would normally use <RAmiga>-N (find next) after the first search
Funny that RAmiga-N has been a reserved shortcut for "New" since forever :-)

Re: Bug in Multiview Search requester

Posted: Sat Sep 19, 2015 5:28 am
by Steady
Actually, I just saw a similar problem in an ASL requester (well, I assume it was ASL) last night and forgot where it was. It might be a problem in some very common code. When I remember/repeat it I will post where it was.

Re: Bug in Multiview Search requester

Posted: Sat Sep 19, 2015 2:00 pm
by broadblues
@Steady

Yes this has been marked as a duplicate of another more general bug, previously thought fixed that seems to have reooccurred (possibly with different cause) in FE.

Re: Bug in Multiview Search requester

Posted: Sat Sep 19, 2015 7:28 pm
by xenic
trixie wrote:
Since you would normally use <RAmiga>-N (find next) after the first search
Funny that RAmiga-N has been a reserved shortcut for "New" since forever :-)
Unless one could afford to buy the Amiga ROM Kernal Manuals, most programmers probably never saw the "Style Guide" and just used keyboard shortcuts that made sense to them. Apparently, the devs have done the same. For example:
RAmiga-N is used in the Workbench/Window menu for "New drawer" instead of Style Guide "Project/New".
RAmiga-P is used in the Workbench/Icon menu for "Put away" instead of Style Guide "Project/Print".
RAmiga-S is used in the Workbench/Icon menu for "Snapshot" instead of Style Guide "Project/Save As...".
RAmiga-S is used in the GUI prefs Settings menu for "Use Seperate Screen" instead of Style Guide "Project/Save As...".
RAmiga-A is used in console/shell Project menu for "Save history" instead of Style Guide "Project/Save As...".

I could probably spend at least a week listing inconsistancies between the Style Guide and the OS. The bottom line is that "Do as I say not as I do" doesn't work and changing Multiview or any OS menu shortcut will just cause confusion at this point.